Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAMM] Fix wrong restHandler for ReplaceMigrationRecordsProposal #5356

Merged
merged 2 commits into from
May 30, 2023
Merged

[GAMM] Fix wrong restHandler for ReplaceMigrationRecordsProposal #5356

merged 2 commits into from
May 30, 2023

Conversation

ThanhNhann
Copy link
Contributor

Closes: #XXX

What is the purpose of the change

ReplaceMigrationRecordsProposal is using the wrong restHandler now so we get the wrong result when using it in #4690

Testing and Verifying

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added C:CLI C:x/gamm Changes, features and bugs related to the gamm module. labels May 30, 2023
@ThanhNhann ThanhNhann added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label May 30, 2023
@ThanhNhann ThanhNhann marked this pull request as ready for review May 30, 2023 05:01
mattverse
mattverse approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM

@mattverse mattverse merged commit 025e4c8 into main May 30, 2023
@mattverse mattverse deleted the nhan/fix_wrong_restHandler branch May 30, 2023 07:30
pysel pushed a commit that referenced this pull request Jun 6, 2023
@ThanhNhann @pysel
[GAMM] Fix wrong restHandler for ReplaceMigrationRecordsProposal (#…
fb5cfb9 
…5356)

* fix wrong restHandler

* changelog
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

Assignees
No one assigned
Labels
C:CLI C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThanhNhann @mattverse