Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update all gomod sdk version #5409

Merged
merged 4 commits into from
Jun 3, 2023
Merged

[chore] update all gomod sdk version #5409

merged 4 commits into from
Jun 3, 2023

Conversation

stackman27
Copy link
Contributor

Closes: #XXX

What is the purpose of the change

update sdk to the latest commit

@stackman27 stackman27 changed the title [chore] update sdk version to the latest commit [chore] update gomod Jun 3, 2023
@stackman27 stackman27 changed the title [chore] update gomod [chore] update all gomod sdk version Jun 3, 2023
@stackman27 stackman27 added A:no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Jun 3, 2023
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as e2e passes, nice work on getting expedited proposals and SDK fork updates over the finish line

@p0mvn
Copy link
Member

p0mvn commented Jun 3, 2023

We likely need to set the parameter in the upgrade handler and update e2e test. Also, changelog should be updated

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Jun 3, 2023
@p0mvn p0mvn merged commit e088e01 into main Jun 3, 2023
@p0mvn p0mvn deleted the sis/sdk-update branch June 3, 2023 04:11
pysel pushed a commit that referenced this pull request Jun 6, 2023
* sdk update

* updated cosmos sdk

* updated all go mods

* upgrade handler

---------

Co-authored-by: Roman Akhtariev <roman@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:no-changelog C:app-wiring Changes to the app folder C:x/epochs V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants