fix: add pool manager spot price query to stargate whitelist #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
reviewed
Jun 13, 2023
wasmbinding/stargate_whitelist.go
Outdated
| @@ -93,7 +92,6 @@ func init() { | |||
| setWhitelistedQuery("/osmosis.gamm.v1beta1.Query/CalcExitPoolCoinsFromShares", &gammtypes.QueryCalcExitPoolCoinsFromSharesResponse{}) | |||
| setWhitelistedQuery("/osmosis.gamm.v1beta1.Query/CalcJoinPoolNoSwapShares", &gammtypes.QueryCalcJoinPoolNoSwapSharesResponse{}) | |||
| setWhitelistedQuery("/osmosis.gamm.v1beta1.Query/PoolType", &gammtypes.QueryPoolTypeResponse{}) | |||
| setWhitelistedQuery("/osmosis.gamm.v2.Query/SpotPrice", &gammv2types.QuerySpotPriceResponse{}) | |||
There was a problem hiding this comment.
We can't do this, it'd break any existing contract
There was a problem hiding this comment.
We can keep both though and specify we don't want this one to be used?
There was a problem hiding this comment.
Makes sense since we don't delete the deprecated protos as well
ValarDragon
changed the title
ValarDragon
approved these changes
Jun 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Gamm v2 spot price qurey has been marked deprecated, whilst we have created a new query for spot price in the pool manager.
We did not deprecate it in stargate whitelist though, having the old query still in stargate whitelist.
This PR submits a change so that we use the new query for spot price in stargate whitelist.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)