chore: add CLI autocomplete to makefile #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
added
the
V:state/compatible/no_backport
|
@devbot-wizard help |
|
Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:
|
czarcas7ic
changed the title
p0mvn
pushed a commit
that referenced
this pull request
Aug 29, 2023
* add autocomplete to make file * make bash the shell for makefile in place of sh * changes * add line * remove parent shell print * proper spacing * update changelog * update changelog --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
This PR adds a
install-with-autocompleteMakefile command, which adds the autocomplete to your profile. If using bash, a separate package must be installed in order to get it to work, which this does as well.I considered just adding this to the
installcommand, but I don't think we should be adding things to people's profiles as the default method. Although I do think the majority of people will want to use this method in place of the usual install.Testing and Verifying
This has been tested on:
And all have worked!
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)