refactor: allow zero qualifying balancer shares in CL incentives #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
changed the title
|
devbot add changelog bug allow zero qualifying balancer shares in CL incentives |
|
If this change is intended for v19, I wonder if it would be better to close this PR in favor of #6142 which removes this logic altogether |
AlpinYukseloglu
approved these changes
Aug 25, 2023
|
Discussed offline |
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
* refactor: allow zero qualifying balancer shares * update changelog --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com> (cherry picked from commit ba8652b)
nicolaslara
pushed a commit
that referenced
this pull request
Aug 31, 2023
* refactor: allow zero qualifying balancer shares * update changelog --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Backport from v18.x
Testing and Verifying
Covered by existing tests and taken directly from the
v18.xbranch.