feat: remove osmo multihop discount #6468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devbot help |
|
Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:
|
|
devbot add changelog feat |
czarcas7ic
changed the title
czarcas7ic
requested review from
p0mvn,
mattverse and
AlpinYukseloglu
as code owners
mattverse
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
LGTM! Nice work!
@czarcas7ic Do you think it makes sense to have a single test case with Base Denom: showing that base denom does not account for multihop doscount before having this merged?
|
@mattverse I had kept two tests from the previous feat that had accounted for multihop discount which no longer show a discount. Are those sufficient are you are saying there should be more? |
pysel
pushed a commit
that referenced
this pull request
Sep 27, 2023
* remove osmo multihop discount * update changelog * edit comments * add sanity check that reduced swap fee is no longer applied --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6373
What is the purpose of the change
Actions remaining part of prop 530
Taker fees are already implemented. We just need to remove the multi-hop discount
Testing and Verifying
Much of this PR is removing the specific osmo multi-hop discount logic/tests.
Kept some osmo incentivized multi hop pools in the tests to ensure the discount is no longer applied.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)