Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default params to pool-incentives genesis #655

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

mattverse
Copy link
Member

Due to added validation on genesis on validating whether distr_info in pool-incentives module is non-negative, the default genesis file currently omits error when starting from the initial state.

This PR adds default genesis for distr_info so that it does not omit error when starting chain from the initial state.

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@daniel-farina daniel-farina added this to the 2021 - December Milestone milestone Dec 13, 2021
@ValarDragon
Copy link
Member

Can you fix the test?

@mattverse
Copy link
Member Author

Fixed test: now changed default state to having nil instead of empty struct

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValarDragon ValarDragon merged commit 4641e15 into main Dec 14, 2021
@ValarDragon ValarDragon deleted the mattverse/fix-distr-info-bug branch December 14, 2021 12:24
ValarDragon pushed a commit that referenced this pull request Dec 20, 2021
* Add default params to pool-incentives genesis

* Change default genState of Records to be nil
@mattverse mattverse mentioned this pull request Dec 30, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants