Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better checks for affiliate swap contract in arb filter #6906

Merged
merged 2 commits into from
Nov 21, 2023
Merged

better checks for affiliate swap contract in arb filter #6906

merged 2 commits into from
Nov 21, 2023

Conversation

nicolaslara
Copy link
Contributor

What is the purpose of the change

arb filter was not properly deserializing the messages leading to a panic (referencing empty route array position) on other messages.

Testing and Verifying

added a test

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@nicolaslara nicolaslara requested review from p0mvn and removed request for p0mvn November 21, 2023 09:31
@nicolaslara nicolaslara mentioned this pull request Nov 21, 2023
Closed
6 tasks
@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:no-changelog A:backport/v20.x backport patches to v20.x branch labels Nov 21, 2023
@ValarDragon ValarDragon merged commit 59038f7 into main Nov 21, 2023
1 check passed
@ValarDragon ValarDragon deleted the nicolas/fix-bad-arb-filter-check branch November 21, 2023 13:41
mergify bot pushed a commit that referenced this pull request Nov 21, 2023
@nicolaslara @mergify
better checks for affiliate swap contract in arb filter (#6906)
181a911 
* better checks for affiliate swap contract

* properly unmarshalling

(cherry picked from commit 59038f7)
@mergify mergify bot mentioned this pull request Nov 21, 2023
Merged
p0mvn pushed a commit that referenced this pull request Nov 21, 2023
@mergify @nicolaslara
better checks for affiliate swap contract in arb filter (#6906) (#6909)
290ffae 
* better checks for affiliate swap contract

* properly unmarshalling

(cherry picked from commit 59038f7)

Co-authored-by: Nicolas Lara <nicolaslara@gmail.com>
This was referenced Nov 21, 2023
Closed
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

Assignees
No one assigned
Labels
A:backport/v20.x backport patches to v20.x branch A:no-changelog C:x/txfees V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolaslara @ValarDragon