refactor: auto-set timeout-commit to 4s for faster block times (backport #7180) #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
p0mvn
force-pushed
the
mergify/bp/v21.x/pr-7180
branch
from
e27bc5b to
53c69a3
Compare
p0mvn
reviewed
Dec 22, 2023
cmd/osmosisd/cmd/root.go
Outdated
Comment on lines
306
to
312
| // configure the viper instance to parse home flags | ||
| if err := serverCtx.Viper.BindPFlags(cmd.Flags()); err != nil { | ||
| return err | ||
| } | ||
| if err := serverCtx.Viper.BindPFlags(cmd.PersistentFlags()); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
This seems to be the cause of failures but it is needed to support custom home
p0mvn
force-pushed
the
mergify/bp/v21.x/pr-7180
branch
from
53c69a3 to
49d39ec
Compare
czarcas7ic
approved these changes
Dec 23, 2023
Tested just now. LGTM |
p0mvn
force-pushed
the
mergify/bp/v21.x/pr-7180
branch
from
be95530 to
fe60fd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #7180 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com