Update IBC to emit errors as events #7400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaslara
added
V:state/compatible/no_backport
ValarDragon
approved these changes
Feb 2, 2024
p0mvn
reviewed
Feb 12, 2024
Comment on lines
+387
to
+388
| // cometbft is replaced to print custom app hash logs. Using branch nicolas/v0.37.4-v23-osmo-1. Need to tag this before releasing | ||
| github.com/cometbft/cometbft => github.com/osmosis-labs/cometbft v0.0.0-20240201155058-95b5f9262e1d |
There was a problem hiding this comment.
all for the comment change, but this has already been merged
p0mvn
added
V:state/compatible/backport
mergify bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
* update IBC to emit errors as events * changelog (cherry picked from commit 6705b46) # Conflicts: # go.mod # go.sum # osmoutils/go.mod # osmoutils/go.sum # x/epochs/go.sum # x/ibc-hooks/go.sum
p0mvn
added a commit
that referenced
this pull request
Feb 12, 2024
p0mvn
added a commit
that referenced
this pull request
Feb 12, 2024
p0mvn
added a commit
that referenced
this pull request
Feb 12, 2024
p0mvn
added a commit
that referenced
this pull request
Feb 12, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
cosmos/ibc-go#5541 has been released. This is something we've been needing for a while so that we can provide proper errors to users of ibc hooks.
Testing and Verifying
Added a check on an existing test that shows the event being emitted.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)