Semantic versioning for osmosis v5.x #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
reviewed
Jan 25, 2022
| @@ -29,5 +29,5 @@ Mgoogle/protobuf/any.proto=github.com/cosmos/cosmos-sdk/codec/types:. \ | |||
| $(find "${dir}" -maxdepth 1 -name '*.proto') | |||
| done | |||
|
|
|||
| cp -r ./github.com/osmosis-labs/osmosis/* ./ | |||
| cp -r ./github.com/osmosis-labs/osmosis/v*/x/* x/ | |||
There was a problem hiding this comment.
Oh cool, did you test make proto-gen on this branch and it works?
There was a problem hiding this comment.
Yep! With this included, proto doesn't get confused where it should generate the proto files even with the go semantic versioning included.
With this not included: proto-gen generates proto file by making a new directory v5, which is the case we don't want
ValarDragon
approved these changes
Jan 25, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #621
Description
This PR adds semantic versioning for v5 in the imports. It also includes change in
generate-proto.shto ensure proto files get generated in the proper directory.For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer