Remove wasm times from our antehandler checkTx + recheckTx stack

[ValarDragon]

These codepaths get called in checktx and rechecktx, causing notable overhead. This PR removes these.

We should get this into a patch release to significantly improve our spam resistance

[github-actions]

Important Notice

This PR modifies an in-repo Go module. It is one of:

• osmomath
• osmoutils
• x/ibc-hooks
• x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
2. Provide the current branch name
3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

[coderabbitai]

Walkthrough

The recent updates enhance efficiency and logic flow in handling IBC transactions. Conditional checks were added in wasm_hook.go and ibc_module.go to optimize processing based on transaction context, improving performance and clarity in the IBC system.

Changes

File	Change Summary
x/ibc-hooks/wasm_hook.go x/ibc-rate-limit/ibc_module.go	Conditional checks added in OnAcknowledgementPacketOverride and OnAcknowledgementPacket methods to optimize processing based on transaction context.

🐇✨ In code we trust, with bytes so bright,
We check and recheck, ensuring the light.
Through hooks and modules, our logic does flow,
With each packet's journey, our system does grow.
Efficiency and clarity, our goals in sight,
In the world of IBC, we code with delight.

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

• Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
• Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
• Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

• Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
• Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
• High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
• Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0ed3f01 and baf26c6.

Files selected for processing (1)

• CHANGELOG.md (2 hunks)

Additional Context Used

Markdownlint (9)

CHANGELOG.md (9)

1055: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

---

1067: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

---

1076: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

---

1081: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

---

1133: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

---

394: Punctuation: '.'
Trailing punctuation in heading

---

657: null
Bare URL used

---

715: null
Bare URL used

---

1296: null
No empty links

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (4)

CHANGELOG.md (4)

Line range hint 394-394: Consider removing the trailing punctuation in the heading for consistency.

-## [v6.4.0].
+## [v6.4.0]

---

Line range hint 657-657: Avoid using bare URLs. Provide descriptive text for hyperlinks for better readability and SEO.

Would you like me to generate the markdown code to replace these bare URLs with descriptive text links?

Also applies to: 715-715

---

Line range hint 1055-1055: Ensure heading levels increment by only one level at a time for proper document structure and accessibility.

Consider adjusting the heading levels accordingly.

Also applies to: 1067-1067, 1076-1076, 1081-1081, 1133-1133

---

Line range hint 1296-1296: Ensure that there are no empty links in the document to improve accessibility and user experience.

- [v6.4.0]()
+ [v6.4.0](link-to-the-specific-section-or-external-resource)

[ValarDragon]

spellcheck failure is unrelated to this PR

[nicolaslara]

This may mean that we include more "bad" txs in the blocks as we don't reject them from the mempool, but that should be fine. An example would be a cross chain swap that has a bad price

[ValarDragon]

but that was never the job of CheckTx to do, e.g. thats not done for swaps!

For Cross-chain swaps, you actually want those to get in, to unlock funds from the sender chain faster.