refactor: Directly swap two variables to optimize code

[jingchanglu]

Closes: #XXX

What is the purpose of the change

Directly swap two variables to optimize code

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added unit test that validates ...
• Added integration tests for end-to-end deployment with ...
• Extended integration test for ...
• Manually verified the change by ...

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes?
• Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

• Specification (x/{module}/README.md)
• Osmosis documentation site
• Code comments?
• N/A

[coderabbitai]

Walkthrough

The pull request modifies the Swap method of the pairs type in the osmoutils/sumtree/tree_test.go file. The original implementation used a temporary variable to swap elements at indices i and j, while the updated version employs Go's tuple assignment feature to streamline the operation into a single line. This change reduces the code length and improves readability without changing the functionality of the method.

Changes

File	Change Summary
osmoutils/sumtree/tree_test.go	Modified the Swap method to use Go's tuple assignment for swapping elements, reducing code lines.

Sequence Diagram(s)

sequenceDiagram
    participant P as pairs
    participant A as Swap Method
    participant T as Temporary Variable (Old Implementation)

    P->>A: Call Swap(i, j)
    A->>T: Assign p[i] to temp
    A->>A: Assign p[j] to p[i]
    A->>T: Assign temp to p[j]
    A-->>P: Return

Loading

sequenceDiagram
    participant P as pairs
    participant A as Swap Method (New Implementation)

    P->>A: Call Swap(i, j)
    A->>A: Assign p[i], p[j] = p[j], p[i]
    A-->>P: Return

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3e52449 and cc08d8a.

Files selected for processing (1)

• osmoutils/sumtree/tree_test.go (1 hunks)

Files skipped from review due to trivial changes (1)

• osmoutils/sumtree/tree_test.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[PaddyMc]

Hey, thanks for the PR, for optimisation PRs we would love to see some benchmark stats as well

Lmk if you can benchmark 🙇