Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osmosis v3 Semver updates #875

Merged
merged 7 commits into from
Mar 30, 2022
Merged

Osmosis v3 Semver updates #875

merged 7 commits into from
Mar 30, 2022

Conversation

faddat
Copy link
Member

@faddat faddat commented Feb 16, 2022

Closes: #788

Description

This PR fixes issues found in semver for osmosis v3

it also:

  • Updates tendermint to v0.34.15
  • Provides rocksdb support
  • Updates tm-db

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v3.x@f86c90f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v3.x     #875   +/-   ##
=======================================
  Coverage        ?   18.23%           
=======================================
  Files           ?      137           
  Lines           ?    21848           
  Branches        ?        0           
=======================================
  Hits            ?     3985           
  Misses          ?    17201           
  Partials        ?      662           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f86c90f...2bc3662. Read the comment docs.

@mattverse
Copy link
Member

Planning to get this reviewed / merged post-superfluid

@mattverse mattverse self-requested a review February 16, 2022 02:28
@faddat
Copy link
Member Author

faddat commented Mar 1, 2022

This no longer uses the replace statement for gorocksdb, and instead uses tm-db v0.6.7

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally update the go version and the cosmos-sdk versions as well?

@faddat
Copy link
Member Author

faddat commented Mar 23, 2022

no and thank you matt!

I remember rememebering that that thad happened, I will make it reverted....

@mattverse
Copy link
Member

Nice! tysm!!

@@ -1,33 +1,122 @@
module github.com/osmosis-labs/osmosis/v3

go 1.15
go 1.17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just bump to 1.18 (including our CI plumbing) while we're at it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely

go.mod Show resolved Hide resolved
@faddat
Copy link
Member Author

faddat commented Mar 30, 2022

@alexanderbez I’m going to handle the go 1.18 stuff, and then open a new pr to bring the iavl changes into the past work

Actually since this is approved, I will leave it as it is and open a new pr that covers:

  • iavl
  • bumped go version

@faddat faddat merged commit a62c955 into v3.x Mar 30, 2022
@faddat faddat deleted the faddat/v3-updates branch March 30, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants