-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Osmosis v3 Semver updates #875
Conversation
Codecov Report
@@ Coverage Diff @@
## v3.x #875 +/- ##
=======================================
Coverage ? 18.23%
=======================================
Files ? 137
Lines ? 21848
Branches ? 0
=======================================
Hits ? 3985
Misses ? 17201
Partials ? 662 Continue to review full report at Codecov.
|
Planning to get this reviewed / merged post-superfluid |
This no longer uses the replace statement for gorocksdb, and instead uses tm-db v0.6.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intentionally update the go version and the cosmos-sdk versions as well?
no and thank you matt! I remember rememebering that that thad happened, I will make it reverted.... |
Nice! tysm!! |
@@ -1,33 +1,122 @@ | |||
module github.com/osmosis-labs/osmosis/v3 | |||
|
|||
go 1.15 | |||
go 1.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just bump to 1.18 (including our CI plumbing) while we're at it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely
@alexanderbez I’m going to handle the go 1.18 stuff, and then open a new pr to bring the iavl changes into the past work Actually since this is approved, I will leave it as it is and open a new pr that covers:
|
Closes: #788
Description
This PR fixes issues found in semver for osmosis v3
it also:
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer