Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE-594 | Delivery package #525
BE-594 | Delivery package #525
Changes from all commits
0fa3729
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused - why do we need this? Cosmos SDK should have all of the GRPC-related packages and libraries with the appropriate codec registered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need to do this here when in the rest of the places we were able to avoid this custom codec logic:
sqs/domain/passthrough/passthrough_grpc_client.go
Lines 72 to 78 in ad494d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great question! Custom codec is required to fix a panic that would occur unmarshaling to
osmomath.LegacyDec
data types otherwise. I have also documented it in the source code here.For example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But LegacyDec is just a string, and we have other messages / queries that function without custom codec.
I'm still unsure why this is necessary.
Is it possible to import this client:
https://github.com/osmosis-labs/osmosis/blob/09ff5a2d72306f5b5a4b4dd29996cb5ab37136d7/x/txfees/keeper/grpc_query.go#L25-L28
and then use this method:
https://github.com/osmosis-labs/osmosis/blob/09ff5a2d72306f5b5a4b4dd29996cb5ab37136d7/x/txfees/keeper/grpc_query.go#L89-L92
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be missing some key details, but it seems that constructing
txfees.NewQuerier
would much more involving since it expects Keeper as parameter:As a reference I was using both node/sqs repos to find examples of how to construct NewQuerier in simple way, but with no results, also I have doubts whether this apporoach would resolve the issue, because it uses same QueryEipBaseFeeResponse as we do here in SQS. This data structure has field
BaseFee
of a typeosmomath.LegacyDec
and I am getting this error with following command too:This issue is documented on cosmos-sdk too: cosmos/cosmos-sdk#18430 (comment)