Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows builds for Python & Go #1442

Merged
merged 6 commits into from
Dec 12, 2021
Merged

Conversation

gj
Copy link
Member

@gj gj commented Dec 11, 2021

Successful run for Python: https://github.com/osohq/oso/runs/4490170722?check_suite_focus=true
Successful run for everything: https://github.com/osohq/oso/actions/runs/1565886995

Believe this shipping in Rust 1.57 is the root cause: rust-lang/rust#84096

@gj gj requested review from saolsen and samscott89 December 11, 2021 00:59
@github-actions
Copy link

github-actions bot commented Dec 11, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@gj gj force-pushed the gj/fix-python-build-on-windows branch from 0c912ee to dcd6d79 Compare December 11, 2021 01:15
@gj gj changed the title Fix python build on windows Fix Windows builds for Python & Go Dec 11, 2021
@samscott89 samscott89 merged commit 2d5e72f into main Dec 12, 2021
@samscott89 samscott89 deleted the gj/fix-python-build-on-windows branch December 12, 2021 22:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants