Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate "maintenance" branch #839

Closed
hdoupe opened this issue Mar 8, 2018 · 3 comments
Closed

Create separate "maintenance" branch #839

hdoupe opened this issue Mar 8, 2018 · 3 comments

Comments

@hdoupe
Copy link
Collaborator

hdoupe commented Mar 8, 2018

I propose that we create a separate maintenance branch for pushing small features and bug fixes. As we phase in the changes for the CPS and benefits data, we will also need to quickly apply patches as bugs are discovered. One case where this would have been useful is yesterday in #836 where a separate branch with reverted changes had to be created in order to apply a minor patch.

@martinholmer
Copy link
Contributor

@hdoupe said in PolicyBrain issue #830:

I propose that we create a separate maintenance branch for pushing small features and bug fixes. As we phase in the changes for the CPS and benefits data, we will also need to quickly apply patches as bugs are discovered. One case where this would have been useful is yesterday in #836 where a separate branch with reverted changes had to be created in order to apply a minor patch.

Why do you need a separate branch?

If several commits have been made to the latest release and you find a bug in the release, simply create the bug-fixing branch from the release (not from the tip of the master branch). I have done this several times over the past half year in my Tax-Calculator work. Here are notes from my policybrain-builder "cheat-sheet":

CREATING NEW BRANCH TO FIX BUG
==============================

==> Fix bug, for example, in release 1.4.0 and then release 1.4.1

$ cd ~/work/OSPC/tax-calculator

$ git checkout master

$ git checkout  -b 1-4-1   1.4.0

... fix bug on branch 1-4-1, test, commit bug fix

$ git push upstream 1-4-1

... create release 1.4.1 using GitHub releases GUI citing branch 1-4-1

... then in order to merge bug-fix into master branch and future releases
    beginning with 1.5.0, do the following:

$ git checkout master

$ git merge 1-4-1

@hdoupe
Copy link
Collaborator Author

hdoupe commented Mar 8, 2018

Ah, this sounds much easier. I was just about to start doing some git gymnastics to get this to work which would have surely caused a problem at some point. Thanks @martinholmer

@hdoupe
Copy link
Collaborator Author

hdoupe commented Mar 8, 2018

Closing #839

@hdoupe hdoupe closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants