Updates to Model Fields

[brittainhard]

No description provided.

[talumbau]

Oh it looks like everything is an AddField for the migration. That's good. I thought certain names changed. @MattHJensen is it the case that the changes in PSLmodels/Tax-Calculator#1109 were just additions to the current_law_policy.json? Did any field change names?

[MattHJensen]

That's right, @talumbau. Here's the relevant comment: PSLmodels/Tax-Calculator#1109 (comment)

[brittainhard]

I'l fix that quickly.
Edit: Looks like those changes have been made.

Regardless. this really needs some review.

Some of the fields I added may have problems, as I could only use other fields as guidelines -- specifically referring to how they correspond to current_law_policy.json

[talumbau]

Yes, I'm looking at it closely because there are a number of changes. It actually looks good to me, except for the STD_Dep parameter. It appears to be a multi-valued parameter in current_law_policy.json, but in this PR, it's still the single value STD_Dep. I think STD_Dep should be removed and STD_Dep_0, STD_Dep_1, STD_Dep_2, STD_Dep_3, should be added along with STD_Dep_cpi as a NullBooleanField like the other CPI flags. Does that sound right @MattHJensen ?

[MattHJensen]

@talumbau, _STD_Dep has a single value per year (unlike _STD)

https://github.com/open-source-economics/Tax-Calculator/blob/master/taxcalc/current_law_policy.json#L429-L434

[talumbau]

Oops, my fault. Right, so this PR is correct with STD_Dep as just a single attribute on the model.

[brittainhard]

@talumbau @MattHJensen do you think this is ready to merge?

[talumbau]

I'll run this locally, including the migration to see how it goes.

[talumbau]

Ran this locally. Migration looked good. Let's merge and I will push up to production tonight