Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance file upload preview #701

Merged
merged 3 commits into from
Oct 26, 2017
Merged

Enhance file upload preview #701

merged 3 commits into from
Oct 26, 2017

Conversation

GoFroggyRun
Copy link
Contributor

This PR closes #500. A filter, nbsp, is added to disable stripping white spaces. Also modified title name as suggested in #500 by @MattHJensen.

Before this PR, the file upload section looks like:

screen shot 2017-10-12 at 2 16 09 pm

The new file preview looks like:

screen shot 2017-10-12 at 2 00 36 pm

where the uploaded file looks like:

{
    "policy": {
        "_SS_Earnings_c": {"2018": [400000], "2019": [500000], "2020": [600000], "2021": [600000], "2022": [600000], "2023": [600000], "2024": [600000]},
        "_II_em": {"2018": [8000]},
        "_II_em_cpi": {"2018": false,
                       "2020": true},
        "_ALD_InvInc_ec_rt": {"2019": [0.20]}
    }
}

@GoFroggyRun GoFroggyRun mentioned this pull request Oct 12, 2017
@GoFroggyRun GoFroggyRun changed the title Enhance file upload Enhance file upload preview Oct 12, 2017
@martinholmer
Copy link
Contributor

@GoFroggyRun, Thanks for the fixes in pull request #701.

@hdoupe
Copy link
Collaborator

hdoupe commented Oct 25, 2017

@GoFroggyRun this looks good, are you ready for this to be merged?

@GoFroggyRun
Copy link
Contributor Author

@hdoupe Yep.

@hdoupe hdoupe merged commit c40caad into ospc-org:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants