Create respective header.html files for btax and taxbrain
#881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GoFroggyRun Thanks for the PR. This looks good to me. I think re-arranging the |
|
@hdoupe thanks for reviewing. Yes, I plan to work on re-arrangements in another PR. |
|
No problem. Ok, sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #874, this PR separates the header template so that btax and taxbrain would use their own
header.html.This makes future maintenance easier when content in either file needs to be updated.I noticed that there are some other btax HTMLs using files in taxbrain's directory. For instances here and here. In fact
taxbrain /input_form_section.htmlandtaxbrain/includes/params/inputs/param.htmlare extensively used for files within the directorytemplates/btax/includes/params/inputs/. I didn't make separate copies of the two as I think it seems a bit redundant and might make future maintenance even harder whenparam.htmlorinput_form_section.htmlneeds to be updated. Maybe we can rearrange the file/directory structure a bit to resolve this problem.@hdoupe does it make sense? Could you review this PR?