Fix scaling of texture coordinates for previewsurface #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was introduced with commit ba61426. Correct scaling requires that ospray texture map scale is set to the reciprocal of scale factor from Transform2dNode. Also it seemed not to be correct to take scale factor from UsdUVTexture as scale factor for texture map. Instead the scale factor from UsdUVTexture is meant to be applied to the values which are read from the texture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The issue was introduced with commit ba61426. Correct scaling requires that ospray texture map scale is set to the reciprocal of scale factor from Transform2dNode. Also it seems not to be correct to take scale factor from UsdUVTexture as scale factor for texture map. Instead the scale factor from UsdUVTexture is meant to be applied to the values which are read from the texture, but this is not part of this commit.