Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Random as a test dep #56

Merged
merged 1 commit into from
Jul 1, 2019
Merged

add Random as a test dep #56

merged 1 commit into from
Jul 1, 2019

Conversation

KristofferC
Copy link
Contributor

Test still fails locally with

 Test: non_convex.jl
ERROR in LDL_factor: Error in KKT matrix LDL factorization when computing the nonzero elements. The problem seems to be non-convex
ERROR in osqp_setup: Linear systems solver initialization failure
Test Summary: | Pass  Total
non_convex    |    3      3
 Test: polishing.jl
polish_random: Test Failed at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:119
  Expression: isapprox(results.x, x_test, atol=tol)
   Evaluated: isapprox([-0.07834457077462488, 0.06720261781221491, 0.2843906239129448, 0.06109454772892296, -0.008062655163817385, 0.5039243785523424, -0.1950870834524256, 0.4099735503580444, -0.06964359907200932, -0.23977566987501392  …  -0.08383220309627627, 0.1767233494405075, 0.17889294459965768, -0.6012858003864514, 0.5967402127073677, -1.207251040635904, -0.19787853937254393, -0.1113873030915415, 0.43319962004388013, 0.6163373703792243], [0.369834, -0.0209277, 0.068939, -0.604151, 0.60773, -0.715965, -0.128837, -0.593642, 0.928932, 0.678794  …  -0.191354, 1.12286, -0.593261, -0.0932879, 0.0286826, -0.0257784, 0.358456, -0.0693514, -0.00358498, -0.0270959]; atol=0.001)
Stacktrace:
 [1] top-level scope at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:119
 [2] top-level scope at /Users/kristoffer/julia/usr/share/julia/stdlib/v1.2/Test/src/Test.jl:1113
 [3] top-level scope at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:77
 [4] top-level scope at /Users/kristoffer/julia/usr/share/julia/stdlib/v1.2/Test/src/Test.jl:1113
 [5] top-level scope at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:16
polish_random: Test Failed at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:120
  Expression: isapprox(results.y, y_test, atol=tol)
   Evaluated: isapprox([0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, -0.083085447651147, 0.0  …  0.0, -0.2384176091635765, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, -0.01332335063224858], [4.88779e-14, 0.441478, 5.89704e-14, 1.76439e-13, 8.10529e-15, 4.9186e-14, 5.00637e-14, 2.00889e-14, 5.39402e-13, -1.9796e-14  …  0.206435, -0.196264, 1.06762e-14, 0.338783, 7.58781e-10, -0.105739, 3.30014e-13, -4.05467e-14, 3.3212e-14, -0.161755]; atol=0.001)
Stacktrace:
 [1] top-level scope at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:120
 [2] top-level scope at /Users/kristoffer/julia/usr/share/julia/stdlib/v1.2/Test/src/Test.jl:1113
 [3] top-level scope at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:77
 [4] top-level scope at /Users/kristoffer/julia/usr/share/julia/stdlib/v1.2/Test/src/Test.jl:1113
 [5] top-level scope at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:16
polish_random: Test Failed at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:121
  Expression: isapprox(results.info.obj_val, obj_test, atol=tol)
   Evaluated: isapprox(-3.2211271987732575, -6.021607803961248; atol=0.001)
Stacktrace:
 [1] top-level scope at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:121
 [2] top-level scope at /Users/kristoffer/julia/usr/share/julia/stdlib/v1.2/Test/src/Test.jl:1113
 [3] top-level scope at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:77
 [4] top-level scope at /Users/kristoffer/julia/usr/share/julia/stdlib/v1.2/Test/src/Test.jl:1113
 [5] top-level scope at /Users/kristoffer/JuliaPkgEval/OSQP.jl/test/polishing.jl:16

@tkoolen
Copy link
Collaborator

tkoolen commented Jul 1, 2019

Thanks. I see this is to get things to work on Julia 1.2.

As for the test failures (again, on 1.2 only), all I can say right now is that they seem to be real (as in, not just a small tolerance issue). These lines:

ERROR in LDL_factor: Error in KKT matrix LDL factorization when computing the nonzero elements. The problem seems to be non-convex
ERROR in osqp_setup: Linear systems solver initialization failure

are expected though.

@tkoolen tkoolen merged commit fda1c30 into osqp:master Jul 1, 2019
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KristofferC
Copy link
Contributor Author

Failure on 1.2 is likely changes in random number stream for sparse matrices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants