This repository has been archived by the owner on Jan 26, 2025. It is now read-only.
Fixing crash for very large USER_MOTION_SIZE values #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow on large motion files
|
Thank you for fixing the segmentation fault issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #317 and #303 a segmentation fault occurs when compiling with large USER_MOTION_SIZE values, preventing the generation of very long simulations. The error is caused by allocating the array containing the xyz motion in the main function, and thus on the stack. With large motion sizes this leads to a stack overflow causing the crash. The very simple fix is to just declare the xyz variable as a global variable outside the main function putting it into the data section of memory.