-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iron dockerfiles #673
Iron dockerfiles #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Since iron is released, we can go ahead and switch this back to ros2
&& rm -rf /var/lib/apt/lists/* | ||
|
||
# setup sources.list | ||
RUN echo "deb http://packages.ros.org/ros2-testing/ubuntu jammy main" > /etc/apt/sources.list.d/ros2-testing.list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN echo "deb http://packages.ros.org/ros2-testing/ubuntu jammy main" > /etc/apt/sources.list.d/ros2-testing.list | |
RUN echo "deb http://packages.ros.org/ros2/ubuntu jammy main" > /etc/apt/sources.list.d/ros2.list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I couldn't (as of 1hour ago) as apparently several variant packages have not been synced (e.g. simulation, desktop full etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah true. Will wait for those to become available!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that should all be fixed now, but we'll need to do another sync in order to get those out.
@Yadunund We may want to consider doing a sync (not a patch release) in the next couple of weeks. That will get desktop-full
and simulation
out (unblocking this), as well as getting navigation2
out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette @Yadunund any chance the sync can happen sooner rather than later ? it will be pretty odd for the community to have a ROS release without desktop_full available and to wait several weeks to have docker images available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will also point out that we could comment out the desktop-full
and simulation
variants here, and release just the core
, base
, and desktop
docker images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, but is it the option you recommend?
I obviously don't have the entire context but I don't remember a ROS distribution being announced officially without all the metapackages / variants available and that seems an odd precedent to me.
Are there strong blockers to syncing now to finish the initial release so that we can announce a full release and docker image availability? (Looks like no regressions and all packages ready to be synced http://repo.ros2.org/status_page/ros_iron_default.html?q=REGRESSION)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blockers, just made the announcement for the sync https://discourse.ros.org/t/preparing-for-iron-sync-2023-05-31/31674
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
desktop-full
should now be available 😄
More changes will be needed once iron is actually released (ci, manifestes etc). Hopefully the iron release will happen today
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Upstream PR: docker-library/official-images#14759 |
To update once Iron is released to pull package from ros2 main apt repo