Fix assumptions that CMAKE_INSTALL_*DIR paths are relative. #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an absolute path is desired, the CMAKE_INSTALL_FULL_*DIR variables should be used instead of concatenating with CMAKE_INSTALL_PREFIX. Special handling is also needed for pkg-config files.
This was referenced Jul 5, 2020
|
I think that the change proposed is correct, it uses the right variables from GNUInstallDirs. We need to verify that values in pkgconfig and cmake files looks correct when they are generated. |
|
@osrf-jenkins run tests |
mjcarroll
approved these changes
Aug 3, 2020
|
@osrf-jenkins run tests |
1 similar comment
|
@osrf-jenkins run tests |
|
Really struggling to get CI to turn over here, I checked build.osrfoundation.org before kicking this one off, so hopefully we'll be in better shape this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an absolute path is desired, the CMAKE_INSTALL_FULL_*DIR variables should be used instead of concatenating with CMAKE_INSTALL_PREFIX. Special handling is needed for pkg-config files to ensure they use interpolations when possible.
See https://github.com/jtojnar/cmake-snips#assuming-cmake_install_dir-is-relative-path for more information.