-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set friction params in DARTCollision for dart 6.10 #2781
Conversation
I tinkered with enabling the |
They are currently being set in DARTLink; set them in DARTCollision instead if dart 6.10 is in use. Also set the DART friction direction and enable corresponding tests Signed-off-by: Steve Peters <scpeters@openrobotics.org>
49b5421
to
1f017dc
Compare
Setting the collision detector to Bullet fixes the test for me. It's probably another one of those issues where FCL converts simple shapes to meshes. We can fix this by enabling this test only if |
Set bullet collision_detector via PhysicsEngine::SetParam API. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
ok, I've enabled the test in 9f706fe |
I don't check |
@osrf-jenkins run tests |
test look ok; the only semi-related test failure was from the MaximumDissipation friction test, but I've seen that flake multiple times: |
also, I believe all these tests were with dart 6.9.4, so none of the new tests actually ran in CI, though I've tested them locally |
They are currently being set in DARTLink; set them in DARTCollision instead if dart 6.10 is in use. Also for 6.10, set the friction direction parameter for DART and enable corresponding tests.