Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set friction params in DARTCollision for dart 6.10 #2781

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 9, 2020

They are currently being set in DARTLink; set them in DARTCollision instead if dart 6.10 is in use. Also for 6.10, set the friction direction parameter for DART and enable corresponding tests.

@scpeters scpeters requested a review from azeey July 9, 2020 01:07
@scpeters
Copy link
Member Author

scpeters commented Jul 9, 2020

I tinkered with enabling the DirectionNaN for dart in scpeters@b2623da, but it has a weird behavior. @azeey if you have a chance to review this PR, perhaps you might have some ideas about why that test is failing?

@scpeters scpeters changed the base branch from gazebo11 to gazebo10 July 9, 2020 01:23
@scpeters scpeters added the 10 Gazebo 10 label Jul 15, 2020
They are currently being set in DARTLink; set them in DARTCollision
instead if dart 6.10 is in use.
Also set the DART friction direction and enable corresponding tests

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters force-pushed the dart_friction_dir_10 branch from 49b5421 to 1f017dc Compare August 27, 2020 21:54
@azeey
Copy link
Collaborator

azeey commented Sep 15, 2020

I tinkered with enabling the DirectionNaN for dart in scpeters@b2623da, but it has a weird behavior. @azeey if you have a chance to review this PR, perhaps you might have some ideas about why that test is failing?

Setting the collision detector to Bullet fixes the test for me. It's probably another one of those issues where FCL converts simple shapes to meshes. We can fix this by enabling this test only if HAVE_DART_BULLET is true and set the collision detector using DARTPhysics::SetParam. Alternatively, since this test uses boxes, we can use DART's builtin collision detector dart.

Set bullet collision_detector via PhysicsEngine::SetParam API.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

I tinkered with enabling the DirectionNaN for dart in scpeters@b2623da, but it has a weird behavior. @azeey if you have a chance to review this PR, perhaps you might have some ideas about why that test is failing?

Setting the collision detector to Bullet fixes the test for me. It's probably another one of those issues where FCL converts simple shapes to meshes. We can fix this by enabling this test only if HAVE_DART_BULLET is true and set the collision detector using DARTPhysics::SetParam. Alternatively, since this test uses boxes, we can use DART's builtin collision detector dart.

ok, I've enabled the test in 9f706fe

@scpeters
Copy link
Member Author

I tinkered with enabling the DirectionNaN for dart in scpeters@b2623da, but it has a weird behavior. @azeey if you have a chance to review this PR, perhaps you might have some ideas about why that test is failing?

Setting the collision detector to Bullet fixes the test for me. It's probably another one of those issues where FCL converts simple shapes to meshes. We can fix this by enabling this test only if HAVE_DART_BULLET is true and set the collision detector using DARTPhysics::SetParam. Alternatively, since this test uses boxes, we can use DART's builtin collision detector dart.

ok, I've enabled the test in 9f706fe

I don't check HAVE_DART_BULLET, so if the dart-bullet component is not installed, I think the test will fail, but I think that's ok

@azeey
Copy link
Collaborator

azeey commented Sep 23, 2020

@osrf-jenkins run tests

@scpeters
Copy link
Member Author

test look ok; the only semi-related test failure was from the MaximumDissipation friction test, but I've seen that flake multiple times:

@scpeters
Copy link
Member Author

also, I believe all these tests were with dart 6.9.4, so none of the new tests actually ran in CI, though I've tested them locally

@scpeters scpeters merged commit 18b729b into gazebosim:gazebo10 Sep 24, 2020
@scpeters scpeters deleted the dart_friction_dir_10 branch September 24, 2020 16:38
@scpeters scpeters mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10 Gazebo 10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants