-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for frame semantics with nested models in SDFormat 1.7 #2824
Conversation
…rt frame semantics Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
this needs the sdformat 9.3 prerelease; the following will enable it in CI: gazebo-tooling/gzdev#18 |
gazebosim/gazebo-classic#2824 needs prerelease version of sdformat 9.3.0. Revert this after stable release of sdformat 9.3.0. * travis: run gzdev.py repository list This checks for syntax errors in plugins/config/repository.yaml Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Relates #2817 |
@osrf-jenkins run tests please |
1 similar comment
@osrf-jenkins run tests please |
gazebo/physics/Model.cc
Outdated
if (boost::dynamic_pointer_cast<Model>(parentEntity)) | ||
{ | ||
auto parentDom = | ||
boost::dynamic_pointer_cast<Model>(parentEntity)->GetSDFDom(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if you store the result of boost::dynamic_pointer_cast<Model>
before the if
statement, then you can avoid calling it a second time here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Gazebo has a feature where a model can be edited/updated during simulation via a |
@osrf-jenkins run tests please |
I have compared the failing Ubuntu and Homebrew builds with the non-PR CIs (Ubuntu and Homebrew) and I don't think any of the failures are caused by this PR. Most of the failures have occurred on the non-PR CI jobs at some point. The only ones I'm not sure about are:
|
the
I'm not sure what that's about |
I'll try reproducing it locally |
I can't reproduce the test failures; I think it's safe to merge |
Support for nested models is going to be added to SDFormat 1.7 in gazebosim/sdformat#316. This PR adds support in Gazebo for using nested models that utilize the frame semantics features of SDFormat 1.7. Note, however, that since SDFormat 1.7 does not support referencing entities inside nested models, SDFormat 1.7 files that use frame semantics as well as nested references will not be supported.
For example, the following SDFormat file will emit an error because joint
J1
referencesM2::L2
.If such a model is loaded, Gazebo will resolve poses with frame semantics wherever it can and revert to the semantics of SDFormat 1.6 where it can't. In the above example, all the poses except
J1
's will be resolved with SDFormat 1.7 semantics.