LensFlare - allow inheritance #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stener defintion to header
scpeters
reviewed
Apr 13, 2021
|
diff without whitespace: |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
our jenkins builds are not properly reporting style errors (gazebo-tooling/release-tools#446), so I took the liberty of shortening some line lengths to 80 characters and cleaning up some whitespace in 48837d1 |
scpeters
approved these changes
Apr 15, 2021
scpeters
added a commit
to scpeters/gazebo
that referenced
this pull request
Apr 17, 2021
* Add LensFlarePrivate setter methods and move LensFlareCompositorListener defintion to header * Modified LensFlareCompositorListener members to follow PIMPL * Reduce line length and fix whitespace Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: kbjeppes <kaden.b.jeppesen@nasa.gov> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
iche033
reviewed
Apr 17, 2021
|
|
||
| /// \brief Set camera stored in LensFlarePrivate | ||
| /// \param[in] _camera Camera to use in sensor. | ||
| protected: void SetCameraSensor(CameraPtr _camera); |
There was a problem hiding this comment.
note that _camera can be either a camera sensor or a user camera but this name suggests that it needs to be a camera sensor.
Maybe something like SetCameraImp? We've used the the *Imp suffix in other places for internal functions.
There was a problem hiding this comment.
nice catch! updating to LensFlare::SetCameraImpl in #2975
scpeters
added a commit
to scpeters/gazebo
that referenced
this pull request
Apr 19, 2021
This is an adjustment to API added in gazebosim#2965, which is allowed because the API has not yet been released. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Apr 19, 2021
This is an adjustment to API added in #2965, which is allowed because the API has not yet been released. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/gazebo
that referenced
this pull request
Apr 19, 2021
* Add LensFlarePrivate setter methods and move LensFlareCompositorListener defintion to header * Modified LensFlareCompositorListener members to follow PIMPL * Reduce line length and fix whitespace Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: kbjeppes <kaden.b.jeppesen@nasa.gov> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/gazebo
that referenced
this pull request
Apr 19, 2021
This is an adjustment to API added in gazebosim#2965, which is allowed because the API has not yet been released. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Apr 20, 2021
* Add LensFlarePrivate setter methods and move LensFlareCompositorListener defintion to header * Modified LensFlareCompositorListener members to follow PIMPL * Reduce line length and fix whitespace Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: kbjeppes <kaden.b.jeppesen@nasa.gov> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Apr 20, 2021
This is an adjustment to API added in #2965, which is allowed because the API has not yet been released. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LensFlarePrivate setter methods and moved LensFlareCompositor definition to header