Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing namespace for string #3211

Merged
merged 2 commits into from
May 3, 2022
Merged

Conversation

Tobias-Fischer
Copy link
Contributor

No description provided.

@Tobias-Fischer
Copy link
Contributor Author

Fixes compile issue

$SRC_DIR/gazebo/msgs/generator/GazeboGenerator.hh:40:23: error: 'string' does not name a type; did you mean 'stdin'?
   40 |                 const string& parameter,
      |                       ^~~~~~
      |                       stdin
$SRC_DIR/gazebo/msgs/generator/GazeboGenerator.hh:42:17: error: 'string' has not been declared
   42 |                 string* error) const;
      |                 ^~~~~~

@traversaro
Copy link
Collaborator

traversaro commented Apr 20, 2022

For reference, this is the Classic Gazebo version of the fix gazebosim/gz-msgs#242, it is useful for Protobuf 3.20 compatibility.

@scpeters scpeters merged commit 2f0f7af into gazebosim:gazebo11 May 3, 2022
@Tobias-Fischer Tobias-Fischer deleted the patch-5 branch May 3, 2022 23:58
scpeters pushed a commit that referenced this pull request Jul 18, 2022
scpeters pushed a commit that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants