Fix shininess and add tests #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for testing. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Confirm that shininess values are properly added to Visuals with shapes_shininess example world. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Reverts a portion of #3223 that broke shininess functionality. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Check that the shininess service exists before trying to call it. This fixes issues with loading the PR2 and related tests. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
jennuine
approved these changes
Jun 20, 2022
* Fix whitespace * Fix copyright year * Remove unneeded includes, add rendering.hh * Fix console message * Add !nullptr asserts Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of the Shininess feature in #3213 caused some test failures in CI that I attempted to fix in #3223, but I accidentally broke the shininess feature entirely. Here's I've added a
Visual::Shininess()accessor to support testing along with tests and a fix.Visual::Shininess()accessor methodINTEGRATION_visual_shininesstest that uses theshapes_shininessdemo world to verify that the/*/shininessservices are working properly (already passing) and checks thatVisual::Shininess()returns the expected values (not passing)Visual::Loadreturning early fromVisual::Load()due to shininess service errors so that other loading may occur.