Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ign-physics3 formula for Dome #1084

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Add ign-physics3 formula for Dome #1084

merged 3 commits into from
Jul 31, 2020

Conversation

j-rivero
Copy link
Collaborator

@j-rivero j-rivero commented Jul 31, 2020 •
edited
Loading

@j-rivero j-rivero requested a review from chapulina July 31, 2020 20:05
@j-rivero
Copy link
Collaborator Author

the thing complains about ruby arrays, let's handle it in #1082 . I'm going to merge this one to check CI again.

@j-rivero j-rivero merged commit cc13d3b into master Jul 31, 2020
@chapulina chapulina deleted the fix_physics3 branch August 1, 2020 01:04
@chapulina
Copy link
Contributor

wow interesting that this PR passed without this: gazebosim/gz-physics#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @chapulina