Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable bottles that depend on tinyxml2 #1490

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Disable bottles that depend on tinyxml2 #1490

merged 2 commits into from
Jun 9, 2021

Conversation

mjcarroll
Copy link
Contributor

Signed-off-by: Michael Carroll michael@openrobotics.org

mjcarroll added 2 commits June 9, 2021 09:58
@mjcarroll
Disable bottles that depend on tinyxml2
53048cd 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Remove bottle block for direct tinyxml2 deps
6aa8c97 
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@j-rivero
Copy link
Collaborator

j-rivero commented Jun 9, 2021

Sorry but I've totally missed the original problem related to tinyxml2 in brew? Do you have a link at hand?

@mjcarroll
Copy link
Contributor Author

homebrew-core bump: Homebrew/homebrew-core#78882

failing job: https://build.osrfoundation.org/job/sdformat11-install_bottle-homebrew-amd64/27/

@j-rivero
Copy link
Collaborator

j-rivero commented Jun 9, 2021

We will need to rebuild the bottles by bumping revisions after this PR, I think is good to go, if something is missing we'll find it a long the way.

@j-rivero j-rivero merged commit 816e665 into master Jun 9, 2021
@j-rivero j-rivero deleted the disable_bottle_tinyxml2 branch June 9, 2021 16:02
@scpeters
Copy link
Member

scpeters commented Jun 9, 2021

this is a good start but we need to remove bottles for recursive dependencies as well

@scpeters
Copy link
Member

scpeters commented Jun 9, 2021

this is a good start but we need to remove bottles for recursive dependencies as well

ah, you've done quite a few, let me see if you've gotten them all

@scpeters
Copy link
Member

scpeters commented Jun 9, 2021

I think we can restore the sdformat9 bottle, since we didn't migrate to tinyxml2 until sdformat10

@scpeters
Copy link
Member

scpeters commented Jun 9, 2021

I think we can restore the sdformat9 bottle, since we didn't migrate to tinyxml2 until sdformat10

reverted for sdformat9 in #1491

This was referenced Jun 9, 2021
Merged
Merged
@scpeters
Copy link
Member

scpeters commented Jun 9, 2021 •
edited
Loading

I've opened #1492 to unbottle the dependents of sdformat10, 11, and 12

we also need to unbottle the dependents of ignition-msgs, ignition-common and our fork of dartsim

This was referenced Jun 9, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Merged
j-rivero added a commit that referenced this pull request Jun 15, 2021
@j-rivero
tinyxml2 fallout: rebuild transport8 bottle
7f2b630 
Follow up to #1490
@j-rivero j-rivero mentioned this pull request Jun 15, 2021
Merged
scpeters pushed a commit that referenced this pull request Jun 15, 2021
@j-rivero @osrfbuild
tinyxml2 fallout: rebuild transport8 bottle (#1511)
2bf9dd6 
Follow up to #1490
* update  bottle.

Co-authored-by: OSRF Build Bot <osrfbuild@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjcarroll @j-rivero @scpeters