Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gazebo11: use new tbb and recent patch #1826

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Conversation

scpeters
Copy link
Member

Use patch from gazebosim/gazebo-classic#3174 and switch to the current version of tbb.

@scpeters
Copy link
Member Author

build bottle

@scpeters
Copy link
Member Author

build bottle

@scpeters scpeters merged commit e174fad into osrf:master Mar 10, 2022
@scpeters scpeters deleted the use_new_tbb branch March 10, 2022 16:05
@Blast545
Copy link

👨‍🌾 It seems this PR caused a build regression in the homewbrew gazebo11 buildfarm, see:
https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/129/

It seems the patch is not being applied properly, as there are a lot of tbb.h deprecation warnings in the log.

@scpeters
Copy link
Member Author

👨‍🌾 It seems this PR caused a build regression in the homewbrew gazebo11 buildfarm, see: https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/129/

It seems the patch is not being applied properly, as there are a lot of tbb.h deprecation warnings in the log.

that build ran before this was merged. I think https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/130/ may have better luck

@traversaro
Copy link
Contributor

👨‍🌾 It seems this PR caused a build regression in the homewbrew gazebo11 buildfarm, see:
https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/129/

It seems the patch is not being applied properly, as there are a lot of tbb.h deprecation warnings in the log.

To be honest I did not check if in the tbb >= 2021 case there where zero deprecation warnings, so the issue could be in the patch as it is, not in how it is applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants