Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PitchMass test easier to maintain #112

Merged
merged 7 commits into from
Dec 15, 2021
Merged

Conversation

chapulina
Copy link
Contributor

We lose some granularity, but in the end of the day, it doesn't matter how quickly the vehicle drifted, just knowing that it drifted is enough to know there's something wrong.

The end goal is to reduce all tolerances to acceptable values throughout the entire mission.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from arjo129 December 9, 2021 23:40
@chapulina chapulina self-assigned this Dec 9, 2021
@arjo129
Copy link
Member

arjo129 commented Dec 10, 2021

Hey @chapulina I actually have written a new version of the test here: https://github.com/osrf/lrauv/blob/2f32e9fdc6e65f8a9a7a048c6e0b2db18e1d1449/lrauv_ignition_plugins/test/test_mission_pitch_mass.cc

I can cherry pick this out in a separate PR if thats what you think is the correct way... I think though we should focus on the garden bump so that the tests in that PR #89 get fixed.

One possibility is we first merge this test and thenm apply the more rigorous test case?

@chapulina
Copy link
Contributor Author

I'm fine going with your test. If you open a PR with just that I think we can get it in faster than if it comes bundled with other changes.

Copy link
Member

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this but, the PR is still failing... I recommend not fussing about this test at all since the behavior is broken. Perhaps it makes sense for now to disable this test completely. I really feel like tweaking this test is going to be a lot of unnecessary effort for you.

@chapulina
Copy link
Contributor Author

Perhaps it makes sense for now to disable this test completely. I really feel like tweaking this test is going to be a lot of unnecessary effort for you.

Fair enough. I'll try to make it as loose as possible, and then we update it properly on #89.

Right now it looks like it failed because of the RDI though:

2021-12-14T04:34:39.746Z,1639456479.746 [MissionManager](ERROR): No startup, active, or default mission!�[0m
2021-12-14T04:34:40.165Z,1639456480.165 [MissionManager](ERROR): No startup, active, or default mission!�[0m
2021-12-14T04:37:52.505Z,1639456672.505 [RDI_Pathfinder](ERROR): Data Fault�[0m
2021-12-14T04:37:52.505Z,1639456672.505 [CBIT](ERROR): Data Fault in component: RDI_Pathfinder�[0m

Let me rerun it

@chapulina chapulina merged commit 30e8b67 into main Dec 15, 2021
@chapulina chapulina deleted the chapulina/pitch_mass_test branch December 15, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants