Absolem: Synchronize Xacro and SDF files, cosmetic changes. #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peci1
force-pushed
the
absolem_fine_tune
branch
from
3a6c253 to
012a2ac
Compare
This was referenced Aug 11, 2020
Closed
acschang
approved these changes
Aug 19, 2020
nkoenig
requested review from
iche033 and
nkoenig
and removed request for
iche033
nkoenig
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't change any simulation behavior. It only transplants the changes made in SDF to the "source" Xacro file, so that after calling
update_robot_sdf, the compiled SDF is the same as the one commited to the repo.I could not align the realsense meshes exactly as they were, but the error in alignment should be within one millimeter.