Send back score of a duplicate report #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org>
iche033
reviewed
Aug 24, 2020
subt_ign/src/GameLogicPlugin.cc
Outdated
| @@ -1317,12 +1317,9 @@ double GameLogicPluginPrivate::ScoreArtifact(const ArtifactType &_type, | |||
| this->LogEvent(stream.str()); | |||
|
|
|||
| this->duplicateReportCount++; | |||
| return 0.0; | |||
| return uniqueReport->second; | |||
There was a problem hiding this comment.
the score change also gets added to the total score here so a duplicate report will end up scoring a point. I think that's not intended? Here's output from a quick test of reporting the same artifact twice which shows a total score of 2 instead of 1:
[Msg] SimTime[10 568000000] OnNewArtifact Msg=type: 5
pose {
position {
x: 191.80000000009215
y: 20.00000000000043
z: -15.069500004108624
}
}
[Msg] [Total]: 1
[Msg] Total score: 1
[Dbg] [VisibilityRfModel.cc:80] Range: 12.3695, Exp: 2.5, TX: 20, RX: -47.3088
[Dbg] [VisibilityRfModel.cc:80] Range: 12.3695, Exp: 2.5, TX: 20, RX: -47.3088
[Msg] SimTime[10 861000000] OnNewArtifact Msg=type: 5
pose {
position {
x: 191.80000000009215
y: 20.00000000000043
z: -15.069500004108624
}
}
[Msg] This report has been received before
[Msg] Total score: 2
Signed-off-by: Nate Koenig <nate@openrobotics.org>
iche033
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolved issue #548.
A duplicate artifact report ACK will now contain
score_change = 1if the original artifact report scored a point, or `score_change = 0' if the original report did not score.Signed-off-by: Nate Koenig nate@openrobotics.org