fix direction of lights on robot robotika/Freyja #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lighting before: Lighting after: Looks good. This will make it into the code freeze. |
|
thanks a lot :) |
|
Is there a way how to check that this was really deployed on CloudSim? We would like to fix also configuration 2 (after "unfreeze") and they both look the same?? |
|
Those lighting issues are due to the javascript library used to render the scene. A fix has been applied here and needs to be rolled out to the portal. The docker images do not require changes. |
|
@nkoenig great - thanks for info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lights unfortunately pointed to the ground - fixed now.
thanks
Martin/Robotika Team