Update position of lights on side of Explorer X1 robot models #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
|
Build finished. 15 tests run, 0 skipped, 0 failed. |
caguero
approved these changes
Nov 4, 2020
nkoenig
approved these changes
Nov 12, 2020
|
I've also updated the models on Fuel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lateral lights on Explorer X1 models are found to be embedded inside the wheels. At certain camera viewing angles, the rendering engine thinks the lights are completely occluded and so the lights become disabled. This fix is to move the lights slightly outside the wheels so it does not get occluded.
The red cubes in the screenshot below represent old pose of lights on the side of the robot:
It was found that the issue is mostly in the GUI camera. As shown in the screenshot below, the light is not visible in the GUI camera but appears fine in the left camera sensor view:
Once this is merged, we'll also need to update the models on Fuel
Signed-off-by: Ian Chen ichen@osrfoundation.org