Better bridge bagger #708
Merged
Better bridge bagger #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 17, 2020 11:03
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
|
Build finished. 15 tests run, 0 skipped, 0 failed. |
peci1
reviewed
Nov 20, 2020
| rosbag::RecorderOptions recorderOptions; | ||
| recorderOptions.append_date=false; | ||
| recorderOptions.split=true; | ||
| recorderOptions.max_splits=1; |
There was a problem hiding this comment.
Yes, please don't make the logs smaller, thanks.
There was a problem hiding this comment.
The previous implementation was incorrect. According to the API, up to 2 GB across 2 log files should be recorded. This equates to 1 split, which allows 2 log files.
This PR will produce up two 2 bag files, each with a maximum of 1GB.
Signed-off-by: Nate Koenig <nate@openrobotics.org>
|
Build finished. 15 tests run, 0 skipped, 0 failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves rosbag from launch into the SubtRosRelay node so that the bag file can be shutdown on
finish. This switch makes sure that the bag file ends cleanly on Cloudsim.