Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model submission for the CERBERUS ANYmal C platform sensor configurations 1 and 2 by CERBERUS #727

Conversation

Samu24
Copy link
Contributor

@Samu24 Samu24 commented Dec 17, 2020

PR adds CERBERUS ANYmal C sensor configuration 1 & 2.

Sensor configuration 1 includes the basic setup for the ANYmal C robot.
Sensor configuration 2 additionally includes 12 breadcrumbs for deployment.

This PR depends on the controller update in leggedrobotics/cerberus_anymal_locomotion#10.

Notes:
The thumbnail script did not work during the preparation. Therefore the thumbnail images are not added yet.

@Samu24
Copy link
Contributor Author

Samu24 commented Dec 17, 2020

fyi @marco-tranzatto

@osrf-jenkins
Copy link

Build finished. 15 tests run, 0 skipped, 0 failed.

@Samu24
Copy link
Contributor Author

Samu24 commented Dec 17, 2020

PR leggedrobotics#1 can be merged into this PR once the recompiled plugin for the dome release has been tested.

…nymal_c_dome_plugin_update

Dome plugin update for CERBERUS ANYmal C
@Samu24
Copy link
Contributor Author

Samu24 commented Dec 18, 2020

@angelacmaio Dome plugin update is merged into this PR.

@osrf-jenkins
Copy link

Build finished. No test results found.

@nkoenig nkoenig requested a review from azeey December 21, 2020 18:25
@azeey azeey self-assigned this Jan 6, 2021
Copy link
Member

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I have tested it locally with the controller from leggedrobotics/cerberus_anymal_locomotion#10. One thing I noticed was that the robot doesn't have a front facing light. Is that intentional?

@nkoenig
Copy link
Contributor

nkoenig commented Jan 7, 2021

@Samu24, can you address the comment by @azeey? Let me know if you have any questions or need assistance.

@Samu24
Copy link
Contributor Author

Samu24 commented Jan 8, 2021

@nkoenig, yes I will have a look.
@azeey, thanks for the review.

The robot should have a forward facing light. There is one in the model.sdf. I can check this again once I manage to overcome #728.

@acschang
Copy link
Contributor

acschang commented Jan 8, 2021

The robot should have a forward facing light. There is one in the model.sdf. I can check this again once I manage to overcome #728.

It seems the light labeled as "forward" actually faces the "rear" with respect to the vehicle spawn and orientation of a positive X velocity request.

@Samu24
Copy link
Contributor Author

Samu24 commented Jan 11, 2021

@acschang, thanks for this comment. I think I see the confusion now. In reality we are using the robot to walk in negative x direction all the time as the cameras and lights are in the rear of the robot. That means "forward" on the real robot is rather "backward"

Given that, would it make sense to introduce a dummy frame that connects the real base to the sim base? I.e. that the robot is rotated 180 degrees and a positive command makes the robot walk in the direction of the cameras and the lights.

@osrf-jenkins
Copy link

Build finished. No test results found.

@acschang acschang self-requested a review January 12, 2021 17:51
Copy link
Contributor

@acschang acschang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comment regarding vehicle orientation in the specifications.md file.

@acschang
Copy link
Contributor

@acschang, thanks for this comment. I think I see the confusion now. In reality we are using the robot to walk in negative x direction all the time as the cameras and lights are in the rear of the robot. That means "forward" on the real robot is rather "backward"

Given that, would it make sense to introduce a dummy frame that connects the real base to the sim base? I.e. that the robot is rotated 180 degrees and a positive command makes the robot walk in the direction of the cameras and the lights.

Thank you for the clarification. A simple note on your convention for operation in the Usage Instructions section of the specifications.md file will be sufficient.

@Samu24 Samu24 requested a review from acschang January 13, 2021 07:54
@osrf-jenkins
Copy link

Build finished. No test results found.

1 similar comment
@osrf-jenkins
Copy link

Build finished. No test results found.

@nkoenig
Copy link
Contributor

nkoenig commented Jan 13, 2021

The bounding box for this model is

Min[-0.599876 -0.316324 -0.503438] Max[0.599877 0.315419 0.284477]

@Samu24 Samu24 requested review from azeey and mjcarroll January 14, 2021 10:36
@osrf-jenkins
Copy link

Build finished. No test results found.

@nkoenig nkoenig merged commit ef8d960 into osrf:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants