Enable topic statistics for breadcrumbs #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org>
|
Build finished. No test results found. |
azeey
reviewed
Jan 9, 2021
Signed-off-by: Nate Koenig <nate@openrobotics.org>
|
Build finished. 15 tests run, 0 skipped, 0 failed. |
Signed-off-by: Nate Koenig <nate@openrobotics.org>
|
Build finished. 21 tests run, 0 skipped, 0 failed. |
azeey
approved these changes
Jan 28, 2021
| @@ -247,6 +247,11 @@ | |||
| <value>$LD_LIBRARY_PATH</value> | |||
| </env> | |||
|
|
|||
| <env> | |||
There was a problem hiding this comment.
nit: I'm not sure why this launch file has this. Shouldn't it be just in cloudsim_sim.ign?
There was a problem hiding this comment.
I put this here so that the behavior is the same when running locally using this launch file and running in the cloud.
| @@ -1,6 +1,8 @@ | |||
| <?xml version="1.0"?> | |||
| <launch> | |||
|
|
|||
| <env name="IGN_TRANSPORT_TOPIC_STATISTICS" value="1"/> | |||
There was a problem hiding this comment.
Probably not needed here as well.
There was a problem hiding this comment.
I think this is needed in order get topic statistics on bridge, I'll double check.
Signed-off-by: Nate Koenig <nate@openrobotics.org>
|
Build finished. 15 tests run, 0 skipped, 0 failed. |
This was referenced Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns on topic statistics for the breadcrumb plugins in order to help address issue #655 .
Requires:
When this is merged and deployed you will see the following in the Ignition Gazebo logs:
Received breadcrumb deployment for X1__breadcrumb__Dropped message count of N for breadcrumbs on model X1__breadcrumb__To Test
ign launch -v 4 competition.ign worldName:=simple_cave_01 circuit:=cave robotName1:=X1 robotConfig1:=X1_SENSOR_CONFIG_8rostopic pub /X1/breadcrumb/deploy std_msgs/EmptySigned-off-by: Nate Koenig nate@openrobotics.org