-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine all circuit launch files #745
Conversation
Build finished. No test results found. |
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
aeb3631
to
cf3cba1
Compare
Build finished. No test results found. |
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Build finished. 15 tests run, 0 skipped, 0 failed. |
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
The wiki has been updated. |
Build finished. 15 tests run, 0 skipped, 0 failed. |
3 similar comments
Build finished. 15 tests run, 0 skipped, 0 failed. |
Build finished. 15 tests run, 0 skipped, 0 failed. |
Build finished. 15 tests run, 0 skipped, 0 failed. |
What about adding some autodetection based on world name? I.e. |
That is what we do in our scripts. I honestly don't even understand why there is such a distinction. |
It sets parameters of the comms model and staging area spawn positions: subt/subt_ign/launch/competition.ign Lines 70 to 92 in 8f5187b
|
But that is the property of the world, right? So why is it set from the outside? The same goes for the spawn positions. |
Signed-off-by: Nate Koenig <nate@openrobotics.org>
I have combined the following circuit launch files into a single file named
competition.ign
:This new change has introduced a new parameter,
circuit
, that must be defined when runningign launch
.circuit
must be eithercave
,tunnel
, orurban
. Here are some example commands:TODO update wiki/READMEs anywhere that are affected by this change?
Signed-off-by: Ashton Larkin ashton@openrobotics.org