Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine all circuit launch files #745

Merged
merged 6 commits into from
Jan 20, 2021
Merged

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Jan 7, 2021

I have combined the following circuit launch files into a single file named competition.ign:

This new change has introduced a new parameter, circuit, that must be defined when running ign launch. circuit must be either cave, tunnel, or urban. Here are some example commands:

  1. run a cave circuit world:
ign launch competition.ign circuit:=cave worldName:=simple_cave_01 robotName1:=X2_3 robotConfig1:=X2_SENSOR_CONFIG_3
  1. run a tunnel circuit world:
ign launch competition.ign circuit:=tunnel worldName:=tunnel_circuit_practice_01 robotName1:=X1 robotConfig1:=X1_SENSOR_CONFIG_1
  1. run an urban circuit world:
ign launch competition.ign circuit:=urban worldName:=urban_qual robotName1:=HUSKY robotConfig1:=COSTAR_HUSKY_SENSOR_CONFIG_1

TODO update wiki/READMEs anywhere that are affected by this change?

Signed-off-by: Ashton Larkin ashton@openrobotics.org

@osrf-jenkins
Copy link

Build finished. No test results found.

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin adlarkin force-pushed the adlarkin/circuit_launch_combination branch from aeb3631 to cf3cba1 Compare January 8, 2021 17:43
@osrf-jenkins
Copy link

Build finished. No test results found.

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin adlarkin marked this pull request as ready for review January 14, 2021 16:03
@adlarkin adlarkin requested a review from nkoenig January 14, 2021 16:03
@osrf-jenkins
Copy link

Build finished. 15 tests run, 0 skipped, 0 failed.

Nate Koenig added 4 commits January 20, 2021 10:03
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig merged commit c6db2c0 into master Jan 20, 2021
@nkoenig
Copy link
Contributor

nkoenig commented Jan 20, 2021

The wiki has been updated.

@osrf-jenkins
Copy link

Build finished. 15 tests run, 0 skipped, 0 failed.

3 similar comments
@osrf-jenkins
Copy link

Build finished. 15 tests run, 0 skipped, 0 failed.

@osrf-jenkins
Copy link

Build finished. 15 tests run, 0 skipped, 0 failed.

@osrf-jenkins
Copy link

Build finished. 15 tests run, 0 skipped, 0 failed.

@peci1
Copy link
Collaborator

peci1 commented Jan 21, 2021

What about adding some autodetection based on world name? I.e. if "cave" in worldName: circuit = "cave" (that's Python syntax, as I don't know Ruby). It'd work for most of the provided worlds, and for those where not (i.e. custom worlds), the user would have to supply it.

@zbynekwinkler
Copy link

What about adding some autodetection based on world name?

That is what we do in our scripts. I honestly don't even understand why there is such a distinction.

@peci1
Copy link
Collaborator

peci1 commented Jan 21, 2021

It sets parameters of the comms model and staging area spawn positions:

$commsFadingExponent = 2.5
$commsScalingFactor = 1.0
$commsRangePerHop = 2.0
if $circuit == "cave"
$commsFadingExponent = 1.5
$commsScalingFactor = 0.55
$commsRangePerHop = 2.0
end
# spawn world offset
if $circuit == "urban"
spawnWorldXPos = 6
spawnWorldYPos = 27
spawnWorldZPos = 7.5
spawnWorldYaw = 0
guiCameraPose = "-2.0 27 15 0 0.868 0"
else
spawnWorldXPos = 0
spawnWorldYPos = 0
spawnWorldZPos = 0
spawnWorldYaw = 0
guiCameraPose = "-6.3 -4.2 3.6 0 0.268 0.304"
end

@zbynekwinkler
Copy link

But that is the property of the world, right? So why is it set from the outside? The same goes for the spawn positions.

AlejoAsd pushed a commit to AlejoAsd/subt that referenced this pull request Sep 15, 2021
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig deleted the adlarkin/circuit_launch_combination branch September 27, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants