Better support running from a local catkin workspace #755
+20
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running a multirobot simulation (or multiple simulations) directly from local catkin workspace has its quirks. This PR addresses them.
~/.ros/robot_data_0.bag
, and only one of them obviously succeeds./tmp/ign/logs
) need a configurable location, so that multiple simultaneous simulations do not write into the same folder./tmp/ign/logs
regardless of the<path>
setting of GameLogicPlugin)I think I saw some initiative towards 2. somewhere (passing a CLI arg with the path instead of having it hardcoded in the launch file), but I can't remember where it was.
Also, the parametrization of ign launch files with the log path would need to modify all of the provided files. I modified just cloudsim_sim.ign, and when we agree whether it's a good approach, I'd modify all of them.
The renaming of robot rosbags might break backwards compatibility for Docker users - the names of the files would change. I'm not sure if this is acceptable or not, but I can imagine some workarounds that would keep the original name if Docker environment is detected (e.g. matching
$USERNAME == developer
, or checking for nonemptyIGN_PARTITION
). Local catkin workspace users would also be affected, but as they were using broken logic anyways, it shouldn't actually hurt them.