Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Submission for MARBLE Husky SC6 #920

Merged
merged 9 commits into from
May 20, 2021

Conversation

acschang
Copy link
Contributor

@acschang acschang commented May 18, 2021

Continuation of #850 and #918. Both of these PRs have a conflicting Husky SC3 from #517 that was never merged and then displaced by #779.

marble_husky_sc6

@bfotheri
Copy link
Contributor

Are any further changes required? @acschang thank you for all your work on this!

Nate Koenig added 2 commits May 19, 2021 16:55
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@acschang
Copy link
Contributor Author

acschang commented May 20, 2021

Are any further changes required? @acschang thank you for all your work on this!

No further changes are required at this time. No problem and thank you for the submission!

Nate Koenig added 3 commits May 20, 2021 09:15
…github.com:osrf/subt into submitted_models/marble_husky_sensor_config_6_redo
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig merged commit ab47492 into master May 20, 2021
@peci1
Copy link
Collaborator

peci1 commented May 20, 2021

This PR somehow brought in the kinetic energy damaged model, however the required ign-gazebo release has not yet been done!

@dan-riley
Copy link

It looks like the additions for marsupial in the competition.ign got dropped off at some point. The offsets are approximately -0.1, 0, 0.45, although it seems the platform isn't fully modeled either.

@angelacmaio
Copy link
Contributor

It looks like the additions for marsupial in the competition.ign got dropped off at some point. The offsets are approximately -0.1, 0, 0.45, although it seems the platform isn't fully modeled either.

@dan-riley can you submit a PR to re-add the platform and marsupial spawn points? Please include a note about the marsupial capability in the specifications.md as well. Are all MARBLE Husky configurations marsupial compatible?

@dan-riley
Copy link

Will do. The other Husky configurations were also meant to have the marsupial capability as well, although we moved on to the new sensor configuration before designing the platform.

@nkoenig nkoenig deleted the submitted_models/marble_husky_sensor_config_6_redo branch September 27, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants