This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
cli: -stdout option for process inspector #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @AkihiroSuda |
| @@ -44,6 +46,7 @@ func init() { | |||
| procFlagset.IntVar(&_procFlags.RootPID, "pid", -1, "PID for the target process tree") | |||
| procFlagset.DurationVar(&_procFlags.WatchInterval, "watch-interval", 1*time.Second, "Watching interval") | |||
| procFlagset.StringVar(&_procFlags.Cmd, "cmd", "", "Command for target process") | |||
| procFlagset.StringVar(&_procFlags.Stdout, "stdout", "", "Stdout for target process (used if -cmd option is given)") | |||
There was a problem hiding this comment.
I think -cmd-stdout is much more descriptive.
If you feel -cmd-stdout is too long, I'm +1 for keeping -stdout
There was a problem hiding this comment.
added -stderr. I think -cmd-stdout is too long because the option is only used with -cmd and it is described in the help message.
|
Thank you a lot for working on this! |
|
@AkihiroSuda thanks for review, updated for the above comment, PTAL. |
| @@ -44,6 +47,8 @@ func init() { | |||
| procFlagset.IntVar(&_procFlags.RootPID, "pid", -1, "PID for the target process tree") | |||
| procFlagset.DurationVar(&_procFlags.WatchInterval, "watch-interval", 1*time.Second, "Watching interval") | |||
| procFlagset.StringVar(&_procFlags.Cmd, "cmd", "", "Command for target process") | |||
| procFlagset.StringVar(&_procFlags.Stdout, "stdout", "", "Stdout for target process (used if -cmd option is given)") | |||
| procFlagset.StringVar(&_procFlags.Stderr, "stderr", "", "Stdout for target process (used if -cmd option is given)") | |||
There was a problem hiding this comment.
the help string is still "Stdout..""
|
@mitake Thank you, please fix the small nit about the help string? |
This commit adds a new option -stdout to process inspector (-cmd mode). A given path will be used for storing stdout of the target process. If the path isn't given, os.Stdout will be used. -stderr does same thing for os.Stderr.
|
@AkihiroSuda ah sorry for that, fixed it, PTAL. |
|
Thank you, merged |
AkihiroSuda
added a commit
that referenced
this pull request
Sep 5, 2016
Release Note: http://osrg.github.io/namazu/post/release-0-2-1/ Changes from v0.2.0: * #167, #168, #169, #170: doc: miscellaneous improvements * #166: vendor go packages * #163: *: bump up Go to 1.7 * #162: container: add support for inspectors/fs * #160: inspectors/fs: implement Fsync * #158, #159: inspectors/fs: improved CLI (thank you @v01dstar !) * #156: inspectors/proc: improved error handling * #154, #155: inspectors/proc: improved CLI Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Merged
AkihiroSuda
added a commit
that referenced
this pull request
Sep 5, 2016
Release Note: http://osrg.github.io/namazu/post/release-0-2-1/ Changes from v0.2.0: * #167, #168, #169, #170: doc: miscellaneous improvements * #166: vendor go packages * #163: *: bump up Go to 1.7 * #162: container: add support for inspectors/fs * #160: inspectors/fs: implement Fsync * #158, #159: inspectors/fs: improved CLI (thank you @v01dstar !) * #156: inspectors/proc: improved error handling * #154, #155: inspectors/proc: improved CLI Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new option -stdout to process inspector (-cmd
mode). A given path will be used for storing stdout of the target
process. If the path isn't given, os.Stdout will be used.
Fixes #152