-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Add bank account transaction integration #132
base: v2
Are you sure you want to change the base?
Conversation
@KMKoushik :) |
I have also added i18n support for this feature in another PR that is based on this PR: #89. If this gets merged I can open a PR with i18n support for this aswell. https://github.com/alexanderwassbjer/split-pro/tree/feature/i18n-support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good overall with some comments. please lemme know what you think!
tysm for this PR really appreciate it. this is really awesome!
think it's best to merge in v2, test thoroughly and release it with other features! (i'll create a new branch)
.env.example
Outdated
@@ -41,6 +41,12 @@ EMAIL_SERVER_PORT= | |||
EMAIL_SERVER_USER= | |||
EMAIL_SERVER_PASSWORD= | |||
|
|||
# GoCardless options | |||
NEXT_PUBLIC_GOCARDLESS_ENABLED= | |||
NEXT_PUBLIC_GOCARDLESS_COUNTRY= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it will work on one specific country alone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it should work world wide. The bank provider picker in the settings page fetch all bank providers. It works with either one country or undefined which then returns all the bank providers.
But because the list can be long in that case, I added the env to have a option to only fetch some.
If you have another approach to this, feel free to tell me.
One way is to have a country picker first and then the providers but it feels a bit weird..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have default currency option, we can get the country from that currency!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find the default currency? If you mean the currency that is set by the user when they try to add a expense it feels a bit weird to use that because it can change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for now, it only works with one country in the package I use. https://github.com/nordigen/nordigen-node/blob/9d535ca9d788115d4e199c749432733be3ea6cdd/lib/api/institutions.js#L23
That can be fixed, either in the package or that we have a country picker first.
But if we think of the user case, will it be necessary to have multiple countries at the same instance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to stick with the env and use it either with no value to fetch all bank providers or filter it based on the env. I have created a PR on the Nordigen-node package and hoping for a merge so we can use it.
nordigen/nordigen-node#63
@alexanderwassbjer changed the base to v2! |
Awesome! Iam happy you liked it. It would be nice if it was released in v2! |
ofcourse this is going to be star feature! |
Co-authored-by: Fredrik Olsson <fredrik.olsson@precisit.com>
Fix bug with floating numbers on exact split calculator
@alexanderwassbjer
|
94bc6d7
to
421b40e
Compare
i'll have to think about this over the weekend! |
…-created-date-in-grouplist Order by expense created date in the groups list
…-page-activity-list-based-on-groupid Redirect to groupexpense or expense in activity list based on groupId
Implemented an integration that uses GoCardless api to fetch bank account transactions. Then when you want to add an expense you can either fill it manually or you can pick from your transactions and it will automatically be added as an expense. There is also a function to "multi add" multiple transactions at the same time.
If a transaction already has been added to a group you cant add it once again.
GoCardless page
Other changes:
Screenshots: