Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a VCS / path curation for flexmark-util #154

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

sschuberth
Copy link
Member

No description provided.

@sschuberth sschuberth requested a review from a team as a code owner December 14, 2023 18:13
@sschuberth sschuberth enabled auto-merge (rebase) December 14, 2023 18:15
- id: "Maven:com.vladsch.flexmark:flexmark-util"
curations:
comment: |
No sources artifact published and no <scm> tag in POM. Repository found via Internet search.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to drop "No sources artifact published" as irrelevant? Maybe also "Repository found via Internet search." ?

idea: we could align on "The package metadata lacks the VCS info." ?

Copy link
Member Author

@sschuberth sschuberth Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reused the wording from the existing https://github.com/oss-review-toolkit/ort-config/blob/main/curations/Maven/com.vladsch.flexmark/flexmark-all.yml which I wanted to align with.

I believe it's not irrelevant that no sources artifact is published, otherwise the question could arise why it's not being used. This makes more clear that fixing the VCS info is our only option, even for users that have configured ORT to prefer source artifacts over VCS locations.

Anyway, whatever wording change we eventually do in the end, it should be applied to flexmark-all, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to drop "No sources artifact published" as irrelevant? Maybe also "Repository found via Internet search." ?

After our discussion, I've dropped the first sentence but kept the second, as to me it's important to explain how a conclusion / curation was achieved. That would be unclear when just stating "The package metadata lacks the VCS info".

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth merged commit 1b50d31 into main Dec 18, 2023
2 checks passed
@sschuberth sschuberth deleted the flexmark-util-vcs branch December 18, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants