Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license-classification: Drop the redundant 'strong-copyleft' category #61

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

fviernau
Copy link
Member

@fviernau fviernau commented Sep 28, 2022

The categories 'copyleft' and 'strong-copyleft' have identical semantics, while 'copyleft' has more usages and aligns with ScanCode's category name. So, align on using 'copyleft' as category for "Strong Copyleft" licenses.

Part of #59.

The categories 'copyleft' and 'strong-copyleft' have identical
semantics, while 'copyleft' has more usages and aligns with ScanCode's
category name. So, align on using 'copyleft' as category for "Strong
Copyleft" licenses.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau fviernau marked this pull request as ready for review September 28, 2022 12:58
@fviernau fviernau requested a review from a team as a code owner September 28, 2022 12:58
@sschuberth
Copy link
Member

AFAIK, the most common terms for the "big three" license categories are "strong copyleft", "weak copyleft", and "permissive". While I agree that here "copyleft" and "strong copyleft" have identical semantics, I would have preferred to align on the more common "strong copyleft" term, and while at it also rename "copyleft-limited" to "weak-copyleft" (assuming that's what's mean with "copyleft-limited").

@fviernau
Copy link
Member Author

fviernau commented Sep 28, 2022

AFAIK, the most common terms for the "big three" license categories are "strong copyleft", "weak copyleft", and "permissive". While I agree that here "copyleft" and "strong copyleft" have identical semantics, I would have preferred to align on the more common "strong copyleft" term, and while at it also rename "copyleft-limited" to "weak-copyleft" (assuming that's what's mean with "copyleft-limited").

This PR is in context of generating the license classification from ScanCode license database and using it in ORT config.
So, I prefer to align with the names of ScanCode.
Given that, do you agree?

@tsteenbe tsteenbe merged commit 4e540a3 into main Sep 28, 2022
@tsteenbe tsteenbe deleted the eliminate-strong-copyleft branch September 28, 2022 13:23
@sschuberth
Copy link
Member

Given that, do you agree?

I guess it's a bit weird for ScanCode to use those names; but yes, for the sake of easily generating the classifications, it make sense to use whatever the source of choice uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants