license-classifications: Improve what gets assigned to the 'include-in-notice-file' category #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not include 'generic' and 'unknown' categories, as the corresponding license IDs do not represent real licenses. Also do no include Contributor License Agreements as these are irrelevant for using the source code or the release artifact respectively. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The generation logic has been changed to stop including licenses of certain categories into the notices. Re-generate the file by using [1] to reflect that. [1] ./gradlew generateLicenseClassifications Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
include-in-notices-adjustments
branch
from
e9b71b8 to
37c3a3b
Compare
tsteenbe
approved these changes
Nov 23, 2022
sschuberth
approved these changes
Nov 25, 2022
Comment on lines
+61
to
+62
| private const val CATEGORY_GENERIC = "generic" | ||
| private const val CATEGORY_UNKNOWN = "unknown" |
There was a problem hiding this comment.
Nit: The extraction of these constants is unrelated to the commit topic.
|
@fviernau Could these categories be included in the ScanCode license DB directly to avoid data fragmentation? They are likely overlapping with some of the license flags .... I guess you are on top of it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Context: #66.