feat(static-html): Order issues by their severity

Adjust the issue summary table (rows), so that errors come first, then warning, then hints. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
oss-review-toolkit · Apr 26, 2024 · e844f82 · e844f82
1 parent 34c7ee7
commit e844f82
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...s/reporters/static-html/src/funTest/assets/static-html-reporter-test-expected-output.html b/...s/reporters/static-html/src/funTest/assets/static-html-reporter-test-expected-output.html
@@ -549,7 +549,7 @@ <h3>Packages</h3>
                   <td>Gradle:org.ossreviewtoolkit.gradle.example:lib:1.0.0</td>
                   <td><a href="#Gradle:org.ossreviewtoolkit.gradle.example:lib:1.0.0">Gradle:org.ossreviewtoolkit.gradle.example:lib:1.0.0</a><ul>
                         <li>
-                           <p>2024-04-25T07:44:20.725613974Z [HINT]: Gradle - Example hint.</p>
+                           <p>2024-04-25T07:44:20.725613974Z [ERROR]: Gradle - Example error.</p>
                            <p></p>
                         </li>
                         <details>
@@ -581,7 +581,7 @@ <h3>Packages</h3>
                               </ul>
                            </details>
                         <li>
-                           <p>2024-04-25T07:44:20.725613974Z [ERROR]: Gradle - Example error.</p>
+                           <p>2024-04-25T07:44:20.725613974Z [HINT]: Gradle - Example hint.</p>
                            <p></p>
                         </li>
                         <details>
@@ -652,7 +652,7 @@ <h3>Packages</h3>
                               </ul>
                            </details>
                         <li>
-                           <p>2024-04-25T07:44:20.725613974Z [HINT]: FakeScanner - Example hint.</p>
+                           <p>2024-04-25T07:44:20.725613974Z [ERROR]: FakeScanner - Example error.</p>
                            <p></p>
                         </li>
                         <details>
@@ -684,7 +684,7 @@ <h3>Packages</h3>
                               </ul>
                            </details>
                         <li>
-                           <p>2024-04-25T07:44:20.725613974Z [ERROR]: FakeScanner - Example error.</p>
+                           <p>2024-04-25T07:44:20.725613974Z [HINT]: FakeScanner - Example hint.</p>
                            <p></p>
                         </li>
                         <details>

diff --git a/plugins/reporters/static-html/src/main/kotlin/ReportTableModelMapper.kt b/plugins/reporters/static-html/src/main/kotlin/ReportTableModelMapper.kt
@@ -98,8 +98,8 @@ internal object ReportTableModelMapper {
                 )
 
                 val isRowExcluded = input.ortResult.isExcluded(row.id)
-                val unresolvedAnalyzerIssues = row.analyzerIssues.filterUnresolved()
-                val unresolvedScanIssues = row.scanIssues.filterUnresolved()
+                val unresolvedAnalyzerIssues = row.analyzerIssues.filterUnresolved().sortedByDescending { it.severity }
+                val unresolvedScanIssues = row.scanIssues.filterUnresolved().sortedByDescending { it.severity }
 
                 if ((unresolvedAnalyzerIssues.isNotEmpty() || unresolvedScanIssues.isNotEmpty())
                     && !isRowExcluded